fix(filesplugin.js): use new version of nextcloud/files #738
+358
−279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
oleksandr-nc
force-pushed
the
fix/NC33-FilesAction
branch
from
6c8071f to
1f20247
Compare
…ation Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
julien-nc
reviewed
Dec 29, 2025
Member
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
- The migration to nextcloud/files v4 is fine 👍
- Offtopic for later or another PR: The
viewparam is not used to decide in which view the action is displayed. Maybe it makes sense to either- Support a
viewFilterparam in the exApp actions which is used as a black/white list in the real action'senabledfunction - Or only enable the action in the
filesview (to always prevent displaying it in the trashbin view and the public view)
- Support a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new
@nextcloud/fileslibrary version, which has breaking changes for AppAPI.Additionally, this PR includes a fix for this issue: #630. We now use async loading for the icon and always register FileAction even if we fail to load the custom icon.
We will see if we can port this fix to older versions(NC32/NC31).